Add multi line text input and drawing input #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add multi line input and drawing input - Add CustomTextView class extending Gtk.TextView and replace Gtk.entry with it - Initialize event handlers and drawing attributes in CustomTextView - Implement button-press-event for drawing in CustomTextView - Implement button-release-event to stop drawing in CustomTextView - Add motion-notify-event for continuous drawing in CustomTextView - Override do_draw method to incorporate drawing functionality in CustomTextView - Refactor _add_smiley_to_entry to support CustomTextView - Refactor _make_entry_widgets to integrate CustomTextView and add drawing button - Extend _entry_activate_cb to serialize drawings as JSON strings and concatenate them with text. - Extend _entry_activate_cb to update logging to include both text and drawing data.
- Initialize empty list all_draw_paths in TextBox's __init__ for storing drawing paths. - Modify add_text to parse both text and drawing data from the input string. Text and drawing data are separated by "||DRAWINGS||" in the input. - Add do_draw method to render drawings stored in `all_draw_paths`. - Update add_text to handle multi-line text inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to issue #17
The code is not working properly and there are still issues with transmiting the drawing and text to the shared activity instance.
As you can see in the commits, I used a custom gtk.TextView to replace the gtk Entry for the input field. One problem I faced was that, if I understand correctly, the sugar's gtk-widgets.css doesn't style textview in a similar way as entry. Would you suggest I manage the css for textview in the source code of chat's activity?
Also, currently when a user sends messages consecutively, they all bundle up in the same box. I was thinking that giving each separate message its own box, would look better. What do you think?
@chimosky @sourabhaa