Masonry module: test coverage gap before integration - prioritization input needed #532
Closed
parthdagia05
started this conversation in
Ideas
Replies: 2 comments
|
The priority order makes complete sense, @parthdagia05. Perhaps it's good to check with @meganindya, @justin212407, and @sa-fw-an in case there's anything needed on the overall structure! |
0 replies
|
@Rishi2600 you can share the documentation here too, so that we can make plan accordingly. The above idea which i shared was in short but a documentation would on it help a lot |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
While exploring the masonry module to integrate in the main, I noticed something
Current state: Only 3 of 8 masonry submodules have any tests at all :-
TowerModel(13 public methods includingconnectBricks,mergeIn,detachSubtree) -- 0 testsWorkspaceManager(6 methods including cross-tower connection) -- 0 testspalette/,state/,tower/utils-- 0 tests--passWithNoTestsflag in the test script means CI passes silently even with no coverageThe 3 files that do have tests (collision-detection, brick path, reverse-mapping) follow clean patterns -- co-located
spec/dirs, data-driven cases, Vitest globals. So the conventions are already established.Since we're planning to integrate masonry into the main app and build snapping and execution on top of it, I think we need a test foundation under
TowerModelandWorkspaceManagerfirst -- these are pure TS classes with no React dependencies, so they're straightforward to unit test.I'd like to start working on this. Before I do, wanted to check with @meganindya @justin212407 @sa-fw-an
All reactions