Search feature flags

[mascarpon3]

Purpose

For beta testing purposes we need to be able to activate Find hybrid search to some users, Find full-text search to some others and leave remaining users on basic DRF title search.

Proposal

The solution proposed is based on django-waffle .

• install waffle and activate the default app in settings.
• implement _get_search_type in DocumentViewset to determine which search type (title, hybrid or full-text) to use.
• send the search_type in the search query.

External contributions

Thank you for your contribution! 🎉

Please ensure the following items are checked before submitting your pull request:

• I have read and followed the contributing guidelines
• I have read and agreed to the Code of Conduct
• I have signed off my commits with git commit --signoff (DCO compliance)
• I have signed my commits with my SSH or GPG key (git commit -S)
• My commit messages follow the required format: <gitmoji>(type) title description
• I have added a changelog entry under ## [Unreleased] section (if noticeable change)
• I have added corresponding tests for new features or bug fixes (if applicable)

[github-actions]

Size Change: +210 B (+0.01%)

Total Size: 4.2 MB

Filename	Size	Change
apps/impress/out/_next/static/856d65ea/_buildManifest.js	830 B	+830 B (new file)	🆕
apps/impress/out/_next/static/898af1f7/_buildManifest.js	0 B	-831 B (removed)	🏆

_{compressed-size-action}

[Copilot]

Pull request overview

This PR implements feature flags for the search functionality using django-waffle, allowing gradual rollout of Find hybrid search and full-text search capabilities to different user groups. The implementation introduces a three-tier search system where users can be assigned different search capabilities through feature flags, with automatic fallback to simpler search methods when needed.

Changes:

• Added django-waffle dependency and integrated it into Django middleware and installed apps
• Implemented SearchType and FeatureFlag enums to define search types and feature flags
• Updated search indexer methods to accept and pass search_type parameter to the Find API
• Added _get_search_type() method in DocumentViewSet to determine search type based on user's feature flags

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/backend/pyproject.toml	Added django-waffle 5.0.0 dependency
src/backend/impress/settings.py	Configured WaffleMiddleware and waffle app
src/backend/core/enums.py	Added SearchType and FeatureFlag enums
src/backend/core/services/search_indexers.py	Updated search methods with search_type parameter and type hints
src/backend/core/api/viewsets.py	Implemented feature flag-based search type selection logic
src/backend/core/tests/test_services_search_indexers.py	Updated tests to use tuple instead of list for visited documents
src/backend/core/tests/test_services_find_document_indexer.py	Updated test to include search_type parameter
src/backend/core/tests/documents/test_api_documents_search_feature_flag.py	New comprehensive test for feature flag behavior
src/backend/core/tests/documents/test_api_documents_search.py	Added fixture to enable hybrid search flag for existing tests
docs/search.md	Documented feature flag usage and priority
CHANGELOG.md	Added entry for new feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The type hint tuple[()] is incorrect syntax. This should be tuple[str, ...] to match the parent class signature in BaseDocumentIndexer and the actual return type of get_visited_document_ids_of. The current syntax is not valid Python type hint syntax for a tuple of strings.

Suggested change

	visited: tuple[()] = (),
	visited: tuple[str, ...] = (),

[Copilot]

The docstring for search_type parameter should include the type annotation (e.g., "search_type (SearchType, optional):") and be more descriptive. It should mention that it can be SearchType.HYBRID or SearchType.FULL_TEXT, and clarify what happens when it's None. Following the pattern of other parameters in this docstring would improve consistency.

Suggested change

	search_type:
	hybrid or full-text search
	search_type (SearchType, optional):
	Type of search to perform. Can be SearchType.HYBRID or SearchType.FULL_TEXT.
	If None, the backend search service will use its default search behavior.

[lunika]

There is a typo in the tests, also spotted by Copilot. Otherwise everything is ok for me