Skip to content

🐛(frontend) fix closing panel#1954

Merged
AntoLC merged 2 commits intomainfrom
fix/home-button-panel-close
Mar 9, 2026
Merged

🐛(frontend) fix closing panel#1954
AntoLC merged 2 commits intomainfrom
fix/home-button-panel-close

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Mar 6, 2026

Purpose

Solve 2 problems:

  • Clicking on the "Home" button is collapsing the left panel.
  • Sliding the panel to the left will collapse it, unsynching the closing states

Demo problems

7d619f21-4844-4f4c-9e9c-d1d643ea9258.webm
Enregistrement.2026-03-09.102903.mp4

@AntoLC AntoLC self-assigned this Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Size Change: -19 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/2e867db0/_buildManifest.js 914 B +914 B (new file) 🆕
apps/impress/out/_next/static/bbaf0987/_buildManifest.js 0 B -911 B (removed) 🏆

compressed-size-action

@AntoLC AntoLC force-pushed the fix/home-button-panel-close branch from 57ec765 to 9119ca8 Compare March 9, 2026 09:23
@AntoLC AntoLC marked this pull request as ready for review March 9, 2026 09:23
@AntoLC AntoLC changed the title Fix/home button panel close 🐛(frontend) fix closing panel Mar 9, 2026
@AntoLC AntoLC added bug Something isn't working frontend labels Mar 9, 2026
@AntoLC AntoLC requested a review from Ovgodd March 9, 2026 09:31
@AntoLC AntoLC force-pushed the fix/home-button-panel-close branch from 9119ca8 to 42b0583 Compare March 9, 2026 10:47
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

AntoLC added 2 commits March 9, 2026 14:03
When clicking on the home button, the left panel was
collapsing, it is a behavior that we want only when
mobile. We improved the logic to only collapse the
panel when we are on mobile devices.
When handling to the left, the panel could totally
collapse, and do beeing unsync with the state of
the left panel (open or closed).
We now keep the collapsing deactivate until
the state of the left panel is closing.
@AntoLC AntoLC force-pushed the fix/home-button-panel-close branch from 42b0583 to 76cb6d6 Compare March 9, 2026 13:04
@AntoLC AntoLC merged commit 76cb6d6 into main Mar 9, 2026
33 of 35 checks passed
@AntoLC AntoLC deleted the fix/home-button-panel-close branch March 9, 2026 13:43
@AntoLC AntoLC mentioned this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants