Fix errors related to users onboarding feature#1971
Merged
Conversation
lunika
force-pushed
the
fix/onboarding
branch
4 times, most recently
from
a8e2ac7 to
cd213f3
Compare
jmaupetit
reviewed
Mar 12, 2026
jmaupetit
left a comment
jmaupetit
left a comment
There was a problem hiding this comment.
I only have minor comments. That's brilliant 👏
src/backend/core/tests/commands/test_clean_onboarding_documents_accesses.py
Outdated
Show resolved
Hide resolved
src/backend/core/tests/commands/test_clean_onboarding_documents_accesses.py
Outdated
Show resolved
Hide resolved
When a user is created, we created accesses to a list of onboarding documents. Doing this have side effect on the proximity search feature. Instead of creating access, we should create link_reach
When a user is created and a sandbox document should be created, we can have a race condition on the document creation leading to an error for the user. To avoid this we have to manage this part in a transaction and locking the document table
We change the strategy on how the new users have access to the onboarding documents. We should remove all created accesses we don't want to have anymore. There is no need to add them in the link_trace table, they are already present in the favorites and user have already access to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In version 4.6.0 we introduce an onboarding feature when a new user is created.
A sandbox document is created for the user
And for onboarding documents accesses were created.
On the sandbox creation we have a race condition when more than one user is created at the same time. This an issue we already had on the document creation, so we fixed it using the same solution : a transaction and a lock on the document table.
For the onboarding documents, we don't create accesses anymore; we use the link_trace table instead. So the documents must not be restricted.
Proposal