Skip to content

♿️(i18n) add "new window" translation key for waffle aria-label#1984

Merged
Ovgodd merged 1 commit intomainfrom
fix/waffle-new-window-trad
Mar 12, 2026
Merged

♿️(i18n) add "new window" translation key for waffle aria-label#1984
Ovgodd merged 1 commit intomainfrom
fix/waffle-new-window-trad

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 12, 2026

Purpose

Add the "new window" translation key for waffle external links aria-label.

Proposal

  • Add the "new window" key in translations.json (all languages)
  • Pass newWindowLabelSuffix={t('new window')} to LaGaufreV2 in Waffle.tsx to localize aria-labels of links opening in a new window (e.g. "Visio (nouvelle fenêtre)" in French)

@Ovgodd Ovgodd requested a review from AntoLC March 12, 2026 09:02
@Ovgodd Ovgodd self-assigned this Mar 12, 2026
@Ovgodd Ovgodd force-pushed the fix/waffle-new-window-trad branch 3 times, most recently from 7599aef to 24d100c Compare March 12, 2026 09:06
@Ovgodd Ovgodd changed the title 🌐(i18n) add "new window" translation key for waffle aria-label ♿️(i18n) add "new window" translation key for waffle aria-label Mar 12, 2026
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 12, 2026
@Ovgodd Ovgodd marked this pull request as ready for review March 12, 2026 09:07
@Ovgodd Ovgodd linked an issue Mar 12, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Size Change: +33 B (0%)

Total Size: 4.22 MB

Filename Size Change
apps/impress/out/_next/static/5fb3c50d/_buildManifest.js 0 B -642 B (removed) 🏆
apps/impress/out/_next/static/803cd425/_buildManifest.js 642 B +642 B (new file) 🆕

compressed-size-action

Comment on lines +47 to +50
<LaGaufreV2Fixed
{...waffleConfig}
newWindowLabelSuffix={t('new window')}
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stay highly customizable it should stay like that:

Suggested change
<LaGaufreV2Fixed
{...waffleConfig}
newWindowLabelSuffix={t('new window')}
/>
<LaGaufreV2Fixed
newWindowLabelSuffix={t('new window')}
{...waffleConfig}
/>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course

@Ovgodd Ovgodd requested a review from AntoLC March 12, 2026 12:45
@Ovgodd Ovgodd force-pushed the fix/waffle-new-window-trad branch 4 times, most recently from e9fd62f to 8486f3a Compare March 12, 2026 15:11
Add key used by LaGaufreV2 for localized aria-label on external links.
@Ovgodd Ovgodd force-pushed the fix/waffle-new-window-trad branch from 8486f3a to 1016b1c Compare March 12, 2026 15:13
@Ovgodd Ovgodd merged commit 1016b1c into main Mar 12, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/waffle-new-window-trad branch March 12, 2026 16:09
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Untranslated title of application links in the waffle

2 participants