Skip to content

♿️(frontend) fix share modal heading hierarchy and title#2007

Merged
Ovgodd merged 1 commit intomainfrom
fix/accessibility-share-modal-headings
Mar 18, 2026
Merged

♿️(frontend) fix share modal heading hierarchy and title#2007
Ovgodd merged 1 commit intomainfrom
fix/accessibility-share-modal-headings

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 16, 2026

Purpose

Fix two accessibility issues in the share modal:

  1. The modal's accessible name was [object Object] and there was a duplicate role="dialog" causing confusion for screen readers.
  2. The heading hierarchy was inconsistent: group names and "Link settings" were not structured as h2 under the h1 "Share the document", and some were hidden from assistive technologies via aria-hidden.
hierarchy sharemodalname

Proposal

  • Fix modal aria-label being [object Object] by passing an explicit string instead of relying on title.toString() on a ReactNode
  • Remove duplicate role="dialog" and aria-label from the inner presentational container
  • Replace the heading prop of Command.Group (which rendered a div with aria-hidden="true") with an explicit <Text as="h2"> for group names (e.g. Shared with X users, Document owner, Pending invitations)
  • Render "Link settings" as h2 in DocVisibility
  • Ensure consistent h1 → h2 heading hierarchy in the share modal

@Ovgodd Ovgodd requested a review from AntoLC March 16, 2026 10:27
@Ovgodd Ovgodd self-assigned this Mar 16, 2026
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 16, 2026
@Ovgodd Ovgodd force-pushed the fix/accessibility-share-modal-headings branch from 1f63b2c to 2d8ca47 Compare March 16, 2026 10:29
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Size Change: +14 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/aa91a702/_buildManifest.js 902 B +902 B (new file) 🆕
apps/impress/out/_next/static/c64a2035/_buildManifest.js 0 B -902 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd marked this pull request as ready for review March 16, 2026 10:42
@Ovgodd Ovgodd marked this pull request as draft March 16, 2026 10:47
@Ovgodd Ovgodd force-pushed the fix/accessibility-share-modal-headings branch from 2d8ca47 to e0c5cdc Compare March 16, 2026 11:00
@Ovgodd Ovgodd mentioned this pull request Mar 16, 2026
@Ovgodd Ovgodd linked an issue Mar 16, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from In review to In progress in LaSuite Docs A11y Mar 16, 2026
@Ovgodd Ovgodd marked this pull request as ready for review March 16, 2026 11:08
@Ovgodd Ovgodd moved this from In progress to In review in LaSuite Docs A11y Mar 16, 2026
@Ovgodd Ovgodd force-pushed the fix/accessibility-share-modal-headings branch 2 times, most recently from f056738 to 18fe04f Compare March 16, 2026 12:13
@Ovgodd Ovgodd changed the title ♿️(frontend) fix share modal heading hierarchy ♿️(frontend) fix share modal heading hierarchy and title Mar 16, 2026
CHANGELOG.md Outdated
- ⬆️(frontend) upgrade Next.js to v16 #1980
- ♿️(frontend) fix aria-label and landmark on document banner state #1986
- 🌐(i18n) add "new window" translation key for waffle aria-label #1984
- ♿️(frontend) fix share modal heading hierarchy #2007
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under Unreleased.

@Ovgodd Ovgodd force-pushed the fix/accessibility-share-modal-headings branch 4 times, most recently from aed287c to 1a052ab Compare March 17, 2026 14:19
Improve h struct in docShareModal use h2 for group names and link settings
@Ovgodd Ovgodd force-pushed the fix/accessibility-share-modal-headings branch from 1a052ab to 1d819d8 Compare March 18, 2026 09:48
@Ovgodd Ovgodd merged commit 1d819d8 into main Mar 18, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/accessibility-share-modal-headings branch March 18, 2026 10:46
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Opening the share modal Incorrect vocalization of the accessible name of the share modal Incorrect heading hierarchy in the share modal

2 participants