♿️(frontend) fix share modal heading hierarchy and title#2007
Merged
Conversation
1f63b2c to
2d8ca47
Compare
|
Size Change: +14 B (0%) Total Size: 4.23 MB
|
This was
linked to
issues
Mar 16, 2026
2d8ca47 to
e0c5cdc
Compare
f056738 to
18fe04f
Compare
AntoLC
approved these changes
Mar 17, 2026
CHANGELOG.md
Outdated
| - ⬆️(frontend) upgrade Next.js to v16 #1980 | ||
| - ♿️(frontend) fix aria-label and landmark on document banner state #1986 | ||
| - 🌐(i18n) add "new window" translation key for waffle aria-label #1984 | ||
| - ♿️(frontend) fix share modal heading hierarchy #2007 |
aed287c to
1a052ab
Compare
Improve h struct in docShareModal use h2 for group names and link settings
1a052ab to
1d819d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix two accessibility issues in the share modal:
[object Object]and there was a duplicaterole="dialog"causing confusion for screen readers.aria-hidden.Proposal
aria-labelbeing[object Object]by passing an explicit string instead of relying ontitle.toString()on a ReactNoderole="dialog"andaria-labelfrom the inner presentational containerheadingprop ofCommand.Group(which rendered a div witharia-hidden="true") with an explicit<Text as="h2">for group names (e.g. Shared with X users, Document owner, Pending invitations)DocVisibility