🐛(backend) allow using search endpoint without refresh token enabled#2097
Open
🐛(backend) allow using search endpoint without refresh token enabled#2097
Conversation
qbey
approved these changes
Mar 20, 2026
The search endpoint was using the refresh_roken method decorator. This decorator force having a valid refresh token stored in the session for the entire viewset. The search endpoint still allow having the legacy search behavior and for this we don't need to configure at all the OIDC refrsh mechanism.
lunika
force-pushed
the
fix/search_without_refresh_token
branch
from
16fc805 to
1df029d
Compare
9 tasks
Contributor
|
how is it solving anything ? when you turn oidc back on to activate Find you will run into the same issue. |
Member
Author
|
This PR is not made to fix the refresh token lifetime but to allow the use of the legacy search when you didn't activate the refresh token storage. So yes, it resolves the main issue we have: using the normal/legacy search without a refresh token stored in the session. It does the same thing you made in your PR, differently, still relying on the django-lasuite middleware when needed. And it was what I mentioned in my last review, and you didn't want to consider it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The search endpoint was using the refresh_roken method decorator. This decorator force having a valid refresh token stored in the session for the entire viewset. The search endpoint still allow having the legacy search behavior and for this we don't need to configure at all the OIDC refrsh mechanism.
Proposal
Fix #2087