♿️(frontend) replace ARIA grid pattern with list in docs grid#2117
Closed
♿️(frontend) replace ARIA grid pattern with list in docs grid#2117
Conversation
Ovgodd
force-pushed
the
fix/docs-grid-aria-list-pattern
branch
from
dd71f4b to
95b700e
Compare
|
Size Change: +331 B (+0.01%) Total Size: 4.23 MB
|
AntoLC
reviewed
Mar 24, 2026
Comment on lines
-36
to
-41
| const handleKeyDown = (e: KeyboardEvent) => { | ||
| if (e.key === 'Enter' || e.key === ' ') { | ||
| e.preventDefault(); | ||
| (e.target as HTMLAnchorElement).click(); | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
I don't have the feeling that we can navigate to a document with the keyboard anymore.
Ovgodd
force-pushed
the
fix/docs-grid-aria-list-pattern
branch
from
689a6a4 to
0092f5d
Compare
Ovgodd
force-pushed
the
fix/docs-grid-aria-list-pattern
branch
from
0092f5d to
6eb0e90
Compare
AntoLC
reviewed
Mar 24, 2026
Collaborator
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
I think we should add a accessibility test on the doc grid, because this comment (#2117 (comment)) highlight that we can have strong regressions passing our tests.
Collaborator
Author
this is a very good idea |
AntoLC
approved these changes
Mar 25, 2026
Collaborator
There was a problem hiding this comment.
Fixup mic mac here:
6eb0e90#diff-4edd7467482bfe24f02a57fcf9723db4a3d93150320de3272eaeb40d02062098R36-R42
Except that LGTM.
Ovgodd
force-pushed
the
fix/docs-grid-aria-list-pattern
branch
from
f07c812 to
525d8c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The document grid used
role="grid"withrole="row",role="gridcell",role="rowgroup", androle="columnheader". This ARIA grid pattern requires full keyboard navigation with arrow keys which it's not implemented and demand to much complexity, . With role="grid", some screen readers switch to a mode where arrow keys are handled by the page; since the page did not implement grid navigation, that interaction did not work as expected.Proposal
role="grid"/role="row"/role="gridcell"/role="columnheader"/role="rowgroup"withrole="list"/role="listitem", matching the actual semantics (a list of documents, not a data grid)Name,Updated at) asaria-hidden="true"since they are no longer part of the list semanticsscreenReaderInstructionsandannouncementsonDndContext(accessibilityprop) so SR copy can be localized via i18n