♿️(frontend) fix empty heading before section titles in HTML export#2125
Open
♿️(frontend) fix empty heading before section titles in HTML export#2125
Conversation
Avoid nested headings: full HTML already wraps content in h1–h6; unwrap
be094e5 to
75c649b
Compare
|
Size Change: -2 B (0%) Total Size: 4.24 MB
|
AntoLC
reviewed
Mar 25, 2026
Collaborator
AntoLC
left a comment
There was a problem hiding this comment.
It is maybe the good moment to add some unit tests on this function improveHtmlAccessibility.
Lists separated by a heading were merged into a single <ul>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
HTML export produced empty headings before real titles (nested
<h1>-<h6>from BlockNote + our pass) and merged lists across headings, breaking outline and list semantics.Proposal
<h1>–<h6>; we no longer add a second heading around it.