Skip to content

♿️(frontend) fix empty heading before section titles in HTML export#2125

Open
Ovgodd wants to merge 4 commits intomainfrom
fix/html-export-empty-heading
Open

♿️(frontend) fix empty heading before section titles in HTML export#2125
Ovgodd wants to merge 4 commits intomainfrom
fix/html-export-empty-heading

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 25, 2026

Purpose

HTML export produced empty headings before real titles (nested <h1>-<h6> from BlockNote + our pass) and merged lists across headings, breaking outline and list semantics.

Proposal

  • Avoid double headings: the exported block already contains an <h1><h6>; we no longer add a second heading around it.
  • Start a new list when list blocks are not adjacent in the DOM (e.g. a heading in between).

@Ovgodd Ovgodd requested a review from AntoLC March 25, 2026 09:02
@Ovgodd Ovgodd self-assigned this Mar 25, 2026
Avoid nested headings: full HTML already wraps content in h1–h6; unwrap
@Ovgodd Ovgodd force-pushed the fix/html-export-empty-heading branch from be094e5 to 75c649b Compare March 25, 2026 09:03
@Ovgodd Ovgodd linked an issue Mar 25, 2026 that may be closed by this pull request
@Ovgodd Ovgodd marked this pull request as ready for review March 25, 2026 09:04
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 25, 2026
@github-actions
Copy link

github-actions bot commented Mar 25, 2026

Size Change: -2 B (0%)

Total Size: 4.24 MB

Filename Size Change
apps/impress/out/_next/static/0dff35eb/_buildManifest.js 0 B -622 B (removed) 🏆
apps/impress/out/_next/static/7c286eb4/_buildManifest.js 622 B +622 B (new file) 🆕

compressed-size-action

Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is maybe the good moment to add some unit tests on this function improveHtmlAccessibility.

@Ovgodd Ovgodd requested a review from AntoLC March 25, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

HTML Export: empty <h2> heading generated before each section h

2 participants