Skip to content

Conversation

@sampaccoud
Copy link
Member

Purpose

When a user is disabled and tries to login, we don't want the user to be duplicated, the user should not be able to login.

Fixes #324

Proposal

  • look for existing user with the same sub (or fallback on email) even if disabled
  • do not allow login for disabled users

@sampaccoud sampaccoud requested review from AntoLC and qbey October 16, 2024 17:07
@sampaccoud sampaccoud self-assigned this Oct 16, 2024
@sampaccoud sampaccoud added bug Something isn't working python Pull requests that update Python code backend labels Oct 16, 2024
@sampaccoud sampaccoud enabled auto-merge (rebase) October 17, 2024 14:45
When a user is disabled and tries to login, we
don't want the user to be duplicated,
the user should not be able to login.

Fixes #324

Work initially contributed by @qbey on:
suitenumerique/people#456
@sampaccoud sampaccoud force-pushed the fix-login-for-disabled-users branch from f1f4f62 to aad80cd Compare October 17, 2024 14:46
@sampaccoud sampaccoud merged commit 6a95d24 into main Oct 17, 2024
15 of 16 checks passed
@sampaccoud sampaccoud deleted the fix-login-for-disabled-users branch October 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled user should not be allowed to login (and create a new duplicated user)

4 participants