Strengthen test assertions by explicitness#127
Merged
Conversation
244def4 to
7262931
Compare
There was a problem hiding this comment.
Pull request overview
Tightens backend test expectations around document bulk indexing/deletion APIs and admin selftest redirects by replacing partial assertions with explicit full-response comparisons and splitting multi-scenario tests into focused cases.
Changes:
- Strengthen API tests by asserting exact
response.json()payloads for bulk indexing and deletion endpoints. - Split “invalid params” coverage in document deletion tests into separate single-scenario tests.
- Make admin selftest redirect assertions more explicit by checking the full redirect URL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/backend/core/tests/test_api_documents_index_bulk.py |
Replaces partial status-only assertions with explicit full response payload equality checks. |
src/backend/core/tests/test_api_documents_delete.py |
Makes delete API assertions fully explicit and splits invalid-parameter scenarios into multiple tests. |
src/backend/core/tests/test_admin_selftest.py |
Updates redirect assertions to check the full expected login redirect URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 8, 2026
fa04269 to
0101931
Compare
jmaupetit
approved these changes
May 11, 2026
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
0101931 to
486da91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert response.json() == {...}checks