Skip to content

Conversation

@suketa
Copy link
Owner

@suketa suketa commented Feb 24, 2025

drop duckdb v1.0.0 support

ruby-duckdb supports duckdb v1.1.x and v1.2.x

Summary by CodeRabbit

  • Chores

    • Refined our testing workflows to phase out support for an older DuckDB version, streamlining compatibility checks across platforms.
    • Adjusted the minimum required DuckDB version to ensure enhanced performance and reliability.
  • Documentation

    • Updated release notes to reflect the revised DuckDB version support and compatibility improvements.

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2025

Walkthrough

This pull request updates the DuckDB version configuration across multiple CI workflow files by removing version 1.0.0 from the testing matrices on macOS, Ubuntu, and Windows. The CHANGELOG.md is updated to document the removal of support for DuckDB v1.0.0 and the bump to version 1.2.0. Additionally, the DuckDB extension configuration in ext/duckdb/extconf.rb now requires at least version 1.1.0 and checks for a different function (from duckdb_appender_column_count to duckdb_result_error_type).

Changes

File(s) Change Summary
.github/workflows/test_on_macos.yml
.github/workflows/test_on_ubuntu.yml
.github/workflows/test_on_windows.yml
Updated the DuckDB version matrix by removing version 1.0.0, leaving ['1.2.0', '1.1.3', '1.1.1'] for CI compatibility tests.
CHANGELOG.md Added an entry under "Unreleased" noting the drop of DuckDB v1.0.0 and documented the version bump to DuckDB v1.2.0.
ext/duckdb/extconf.rb Updated DUCKDB_REQUIRED_VERSION from '1.0.0' to '1.1.0' and modified the function check from duckdb_appender_column_count to duckdb_result_error_type.

Sequence Diagram(s)

sequenceDiagram
    participant Build as Build Process
    participant Config as extconf.rb
    participant DuckDB as DuckDB Library Header

    Build->>Config: Initiate configuration check
    Config->>DuckDB: Verify presence of duckdb_result_error_type (requires v1.1.0)
    DuckDB-->>Config: Return check result
    Config-->>Build: Proceed based on DuckDB library check
Loading

Possibly related PRs

  • bump duckdb 1.2.0 #876: Adds DuckDB version 1.2.0 to the testing matrices, directly relating to the removal of version 1.0.0.
  • prepare to release 1.2.0.0 #890: Involves updates to DuckDB versioning that include removing support for 1.0.0 and bumping to a newer version, similar to the changes in this PR.

Poem

I'm a rabbit in the codeyard, hopping on this trail,
Shedding old versions like leaves with a tail.
DuckDB's now a sprightly friend in testing galore,
Skipping 1.0.0, embracing upgrades to explore.
With a hop and a cheer, my code sings bright,
ASCII winks and bunny beats make our CI light!
🐰 Happy coding, let the workflows take flight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96ab61e and cce4fd5.

📒 Files selected for processing (5)
  • .github/workflows/test_on_macos.yml (1 hunks)
  • .github/workflows/test_on_ubuntu.yml (1 hunks)
  • .github/workflows/test_on_windows.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • ext/duckdb/extconf.rb (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: test (head, 1.1.1)
  • GitHub Check: test (head, 1.1.3)
  • GitHub Check: test (head, 1.2.0)
  • GitHub Check: test (mingw, 1.1.1)
  • GitHub Check: test (3.4.1, 1.1.1)
  • GitHub Check: test (3.4.1, 1.1.3)
  • GitHub Check: test (3.4.1, 1.2.0)
  • GitHub Check: test (3.3.6, 1.1.1)
  • GitHub Check: test (3.3.6, 1.1.3)
  • GitHub Check: test (3.3.6, 1.2.0)
  • GitHub Check: test (3.2.6, 1.1.1)
  • GitHub Check: test (3.2.6, 1.1.3)
  • GitHub Check: test (3.2.6, 1.2.0)
  • GitHub Check: test (3.1.6, 1.1.1)
  • GitHub Check: test (3.1.6, 1.1.3)
  • GitHub Check: test (3.1.6, 1.2.0)
🔇 Additional comments (6)
ext/duckdb/extconf.rb (2)

5-5: LGTM! Version requirement update aligns with PR objective.

The update of DUCKDB_REQUIRED_VERSION to '1.1.0' correctly implements the PR's goal of dropping support for DuckDB v1.0.0.


59-62:

Details

✅ Verification successful

Verify the function availability across supported versions.

The switch from duckdb_appender_column_count to duckdb_result_error_type for version checking suggests an API change. Let's verify this function's availability across the supported versions.


🏁 Script executed:

#!/bin/bash
# Description: Check if duckdb_result_error_type is available in supported versions

# Clone and check each supported version
for version in 1.1.1 1.1.3 1.2.0; do
  echo "Checking DuckDB v$version..."
  git clone --depth 1 -b v$version https://github.com/duckdb/duckdb.git duckdb-$version
  if grep -r "duckdb_result_error_type" duckdb-$version/src/include/duckdb.h > /dev/null; then
    echo "✓ duckdb_result_error_type found in v$version"
  else
    echo "✗ duckdb_result_error_type not found in v$version"
  fi
  rm -rf duckdb-$version
done

Length of output: 4986


Verified: duckdb_result_error_type is available across supported DuckDB versions.

The function check now using duckdb_result_error_type for version verification has been validated. The script confirmed its existence in DuckDB v1.1.1, v1.1.3, and v1.2.0, indicating that the API change is correctly handled.

No further changes are required.

.github/workflows/test_on_windows.yml (1)

19-19: LGTM! Test matrix update aligns with version requirements.

The removal of DuckDB v1.0.0 from the test matrix correctly implements the PR's objective while maintaining tests for v1.1.x and v1.2.x versions.

.github/workflows/test_on_ubuntu.yml (1)

19-19: LGTM! Test matrix update maintains consistency across platforms.

The removal of DuckDB v1.0.0 from the Ubuntu test matrix maintains consistency with the Windows workflow and aligns with the PR's objective.

.github/workflows/test_on_macos.yml (1)

19-19: LGTM! Test matrix update completes cross-platform alignment.

The removal of DuckDB v1.0.0 from the macOS test matrix completes the consistent update across all platforms (Windows, Ubuntu, and macOS).

CHANGELOG.md (1)

5-5: Documentation Update: Removal of DuckDB v1.0.0
This new changelog entry clearly reflects the removal of support for DuckDB v1.0.0, aligning with the PR objectives. Please ensure that all related references (e.g., in CI matrix files and extension configuration) have also been updated accordingly.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@suketa suketa merged commit 3771ec6 into main Feb 24, 2025
58 checks passed
@suketa suketa deleted the drop_duckdb_1.0.0 branch February 24, 2025 02:02
This was referenced Feb 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request May 23, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants