Skip to content

Conversation

@vhiairrassary
Copy link
Contributor

@vhiairrassary vhiairrassary commented Jul 10, 2025

Here is a PoC adding support for Ruby UDFs (AKA known as scalar functions, referenced in the issue #751). It is highly inspired from the official C API example.

The API is inspired from the Python API

DuckDB::Database.open do |db|
  db.connect do |con|
    con.register_scalar_function(
      "my_func", return_type: :integer, parameter_types: [:integer, :integer]
    ) do |x1, x2|
      (x1 + x1) * x2
    end

    result = con.query("SELECT my_func(2, 5)")
    assert_equal(result.column_count, 1)
    assert_equal(result.to_a, [[20]])
  end
end

More basic examples are available in test/duckdb_test/scalar_functions_test.rb.

The code change is more a WIP than anything else, but if you are interested about it then I would be happy to make it production ready (and if you are OK with the general structure of the change). Feedback is more than welcome.

Remaining tasks:

  • Support returning nil
  • Remove dynamic allocations in C function handler by fixing a maximum number of parameters
  • Support volatile functions
  • Types support
    • TEXT
    • INTEGER
    • DATE
    • BOOL
    • UUID
    • ARRAY
    • STRUCT
    • MAP
  • Resolve remaining TODOs

EDIT: It seems there are some segfaults in the CI, I have tested it only on macOS so far. It seems to happen only when there is an exception raised in the UDF. It can be reproduced with a IRB terminal (with ./bin/console), with LLDB attached to it using the following script:

(0..1000).each do |n|
  DuckDB::Database.open do |db|
    db.connect do |con|
      con.register_scalar_function("my_func", return_type: :integer) do
        raise StandardError, 'BOOM'
      end

      begin
        result = con.query('SELECT my_func()')
      rescue
        nil
      end

      puts "#{Time.now} - #{n} - #{result.to_a}"
    end
  end
end

@coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vhiairrassary vhiairrassary force-pushed the vhiairrassary/add-udf-support branch 3 times, most recently from fc93cff to 5c4b7e2 Compare July 13, 2025 18:29
@vhiairrassary vhiairrassary force-pushed the vhiairrassary/add-udf-support branch from 5c4b7e2 to 4f0c32e Compare July 14, 2025 07:11
@vhiairrassary
Copy link
Contributor Author

A new PR has been merged to implement scalar functions (#970), so let's close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant