Cmake errors on Windows

[sum01]

From latest Windows build, there are multiple LNK warnings/errors on the add_appveyorci branch

Main errors that are crashing the build

1. coin.lib(db.obj) : error LNK2019: unresolved external symbol "public: __cdecl Db::Db(class DbEnv *,unsigned int)" (??0Db@@QEAA@PEAVDbEnv@@I@Z) referenced in function "public: __cdecl coin::db::db(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??0db@coin@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z) [C:\projects\vcash\vcashd.vcxproj] First appearance
2. coin.lib(db_env.obj) : error LNK2001: unresolved external symbol "public: __cdecl Db::Db(class DbEnv *,unsigned int)" (??0Db@@QEAA@PEAVDbEnv@@I@Z) [C:\projects\vcash\vcashd.vcxproj] First appearance
3. coin.lib(db.obj) : error LNK2019: unresolved external symbol "public: virtual __cdecl Db::~Db(void)" (??1Db@@UEAA@XZ) referenced in function "public: static bool __cdecl coin::db::rewrite(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char const *)" (?rewrite@db@coin@@SA_NAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEBD@Z) [C:\projects\vcash\vcashd.vcxproj] First appearance

Lesser errors

This one seems inconsequential, considering CMake finishes without any issues. Link

C:\projects\vcash\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\projects\vcash\CMakeFiles\CMakeTmp\cmTC_d0206.vcxproj]
Done Building Project "C:\projects\vcash\CMakeFiles\CMakeTmp\cmTC_d0206.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\projects\vcash\CMakeFiles\CMakeTmp\cmTC_d0206.vcxproj" (default target) (1) ->
(ClCompile target) -> 
  C:\projects\vcash\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\projects\vcash\CMakeFiles\CMakeTmp\cmTC_d0206.vcxproj]
    0 Warning(s)
    1 Error(s)
Time Elapsed 00:00:01.49

Warnings

1. rpc_json_parser.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\vcash\coin.vcxproj] A StackOverflow post mention fixing this by changing link ordering.
2. C:\Program Files (x86)\Oracle\Berkeley DB 12cR1 6.1.36\lib\libdb61.lib : warning LNK4272: library machine type 'x86' conflicts with target machine type 'x64' [C:\projects\vcash\vcashd.vcxproj] First appearance
3. Unknown compiler version - please run the configure tests and report the results Seems related to Boost, unsure of a fix, or if it even matters.

All conversion warnings, probably ignorable.

• warning C4267
• warning C4244
• warning C4334

[sum01]

Latest build

It seems after pulling in my latest changes that it no longer fails on the old errors, but on a new one.
C:\projects\vcash\coin\test\main.cpp(24): fatal error C1083: Cannot open include file: 'boost/asio.hpp': No such file or directory [C:\projects\vcash\vcashd.vcxproj]

No change on the pthreads error.
Warning #2 seems to be gone.

Never mind, back to the same errors...

[sum01]

Down to 15 external errors after some changes to the definitions script.

Note: rpc_json_parser.obj : warning LNK4221 is because coin/src/stack_impl.cpp also includes coin/rpc_json_parser.hpp so it's throwing this error because coin/src/rpc_json_parser.cpp declares nothing new.

[sum01]

Removed the max ver check on BerkeleyDB, downloaded 6.2 64-bit, and now all old errors are gone.

New errors

coin/src/db.cpp(379): error C2589: '(': illegal token on right side of '::'
coin/src/db.cpp(379): error C2062: type 'unknown-type' unexpected
coin/src/db.cpp(380): error C2059: syntax error: ')'
coin/src/db.cpp(381): error C2143: syntax error: missing ';' before '{'
coin/src/db_env.cpp(205): error C2440: '<function-style-cast>': cannot convert from 'int' to 'DbEnv'
coin/src/db_env.cpp(205): error C2228: left of '.remove' must have class/struct/union

Solution? https://stackoverflow.com/questions/2561368/illegal-token-on-right-side-of

[sum01]

Fixed:

coin/src/db.cpp(379): error C2589: '(': illegal token on right side of '::'
coin/src/db.cpp(379): error C2062: type 'unknown-type' unexpected
coin/src/db.cpp(380): error C2059: syntax error: ')'
coin/src/db.cpp(381): error C2143: syntax error: missing ';' before '{'

By adding parentheses around std::min to avoid treating it like a macro if windows.h is used.

---

Previous errors related to db_env.cpp still apply:

coin/src/db_env.cpp(205): error C2440: '<function-style-cast>': cannot convert from 'int' to 'DbEnv'
coin/src/db_env.cpp(205): error C2228: left of '.remove' must have class/struct/union