Skip to content
This repository was archived by the owner on Feb 16, 2021. It is now read-only.

Conversation

@ohvitorino
Copy link
Contributor

The JMSTranslationBundle routes were being loaded in dev but not in prod. But users with ROLE_ADMIN need this routes to be able to perform translations in production environment.
We just needed to move the route definition to the appropriate file.

@StijnVrolijk
Copy link
Contributor

@ohvitorino uw builds falen, kan jij daar eens naar kijken?

@ohvitorino
Copy link
Contributor Author

ohvitorino commented Feb 13, 2017

It has something to do with phpunit returning 1 instead of 0 when there are warnings in the tests.

The test runner now exits with 1 (instead of 0) when all tests pass but there are warnings (see https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed).

On the other hand I guess this only happens on PHPUnit 6.

@ohvitorino
Copy link
Contributor Author

I'll try to fix the warnings since they need to be fixed if we upgrade to Symfony 3.

@StijnVrolijk StijnVrolijk merged commit 8054e0f into master Feb 21, 2017
@tijsverkoyen tijsverkoyen deleted the 150-JMSTranslationBundle-routes-load-prod branch May 23, 2018 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants