fix: remove validate CI job#6
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0187fb6cec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run local test suite | ||
| run: bash tests/test.sh | ||
|
|
||
| smoke-actions: |
There was a problem hiding this comment.
This change removes the only CI step that executes bash tests/test.sh, so pull requests now pass with just the smoke-actions happy-path workflow. That smoke job uses single-attempt settings (install-attempts: 1, attempts: 1) and does not exercise many guardrails covered by the local tests (for example, the invalid-attempt validation and retry behavior in tests/setup-opencode.sh and tests/run-opencode.sh), so regressions in the action scripts can be merged undetected.
Useful? React with 👍 / 👎.
3 tasks
Svtter
added a commit
that referenced
this pull request
May 27, 2026
TS (platform.ts): - Cache detectPlatform() result to avoid repeated env reads (#6) - getRepo() returns empty string + warn instead of throw (#5) - fetchAllGiteaComments() capped at MAX_PAGES=20 (#1) - getGiteaToken() checks both GITEA_TOKEN and GITHUB_RUN_OPENCODE_GITEA_TOKEN (#13) - Add /* ignore */ comments to empty catch blocks (#11) Python (run-github-opencode.py): - Use specific exception types: (TimeoutExpired, JSONDecodeError) not bare Exception (#2) - Add HTTP plaintext warning for GITEA_API_URL (#3) - Validate repo/pr format before URL construction (#4) - Add pagination for Gitea comment listing with max_pages=20 (#1) - Unify token lookup to GITEA_TOKEN only (#13)
Svtter
added a commit
that referenced
this pull request
May 27, 2026
* feat: add Gitea CI compatibility via platform abstraction layer - New platform.ts: auto-detect GitHub/Gitea via GITEA_API_URL env var - Unified interfaces for PR diff fetch, comment posting, error comment cleanup - Gitea: tea CLI (preferred) → curl REST API fallback - GitHub: unchanged, zero-impact on existing workflows - comment.ts refactored to thin proxy over platform.ts - index.ts: platform-aware diff fetch with pre-fetched file fallback - action.yml (multi-review, review): new gitea-token input - Python: detect_platform() + Gitea error comment cleanup Closes #55 * fix: address AI code review feedback - Remove dead httpRequest code and unused http/https imports (阻塞项 #1) - Reverse diff fetch priority: pre-fetched file first, platform fetch as fallback to avoid duplicate API calls on GitHub (阻塞项 #2) - Fix redundant Python exception catches (Exception covers subclasses) - Use get_env() in detect_platform() for consistency - Add HTTPS warning for GITEA_API_URL using plain HTTP - Validate GITHUB_REPOSITORY format before API calls - Lazy-cache hasTea() result to avoid repeated which calls - Add pagination support for Gitea comment cleanup - Revert tsup externals (https/http no longer imported) - Remove duplicate empty-diff check in index.ts * fix: address second round AI code review feedback TS (platform.ts): - Cache detectPlatform() result to avoid repeated env reads (#6) - getRepo() returns empty string + warn instead of throw (#5) - fetchAllGiteaComments() capped at MAX_PAGES=20 (#1) - getGiteaToken() checks both GITEA_TOKEN and GITHUB_RUN_OPENCODE_GITEA_TOKEN (#13) - Add /* ignore */ comments to empty catch blocks (#11) Python (run-github-opencode.py): - Use specific exception types: (TimeoutExpired, JSONDecodeError) not bare Exception (#2) - Add HTTP plaintext warning for GITEA_API_URL (#3) - Validate repo/pr format before URL construction (#4) - Add pagination for Gitea comment listing with max_pages=20 (#1) - Unify token lookup to GITEA_TOKEN only (#13) * fix: address third round review feedback - Restore error log in GitHub cleanup catch block (#1) - Add --repo to tea pulls diff call (#2) - Python Gitea token fallback: check both GITEA_TOKEN and GITHUB_RUN_OPENCODE_GITEA_TOKEN (#4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatejob (shellcheck lint + local test suite) from CIsmoke-actionsjob which provides meaningful end-to-end verification