Fix waitpid's behavior on negative pid values.#18
Merged
sunfishcode merged 1 commit intomainfrom Sep 22, 2023
Merged
Conversation
Negative pid values mean to wait for process groups, however this isn't currently working in rustix. As a temporary workaround, have `waitpid` call `wait` in this situation. When bytecodealliance/rustix#846 is released, we can use `waitpgid`, but until then, this workaround gets more things working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative pid values mean to wait for process groups, however this isn't currently working in rustix. As a temporary workaround, have
waitpidcallwaitin this situation.When bytecodealliance/rustix#846 is released, we can use
waitpgid, but until then, this workaround gets more things working.