Set default sort fields and implement pagination on list API endpoints#18
Closed
Glaisher wants to merge 6 commits intosunnah-com:masterfrom
Closed
Set default sort fields and implement pagination on list API endpoints#18Glaisher wants to merge 6 commits intosunnah-com:masterfrom
Glaisher wants to merge 6 commits intosunnah-com:masterfrom
Conversation
Added hadithTable dump as it was missing from initial dump so would need to import HadithTable first for this to work properly.
Default limit: 50 Max limit: 100 Example usage: /v1/collections/bukhari/books/2/hadiths?limit=20&page=2
ahadith
reviewed
Jun 8, 2020
Contributor
ahadith
left a comment
ahadith
left a comment
There was a problem hiding this comment.
Can you please make the very minor changes in the comments and resubmit the pull request with just the last two commits? It will make for a cleaner commit history :)
Member
Author
|
Resubmitted as #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default limit: 50
Max limit: 100
Example usage:
/v1/collections/bukhari/books/2/hadiths?limit=20&page=2