Rename serializer fields #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadith
requested changes
Jun 13, 2020
models.py
Outdated
| 'total_hadith': self.totalhadith, | ||
| 'has_chapters': self.haschapters, | ||
| 'short_intro': self.shortintro, | ||
| 'numhadith': self.numhadith, |
Contributor
There was a problem hiding this comment.
Let's keep the underscore (especially since total_hadith has an underscore). And maybe call it num_available_hadith. And we can explain the difference in the documentation.
Contributor
Author
There was a problem hiding this comment.
Got it, I intended to do so. But somehow missed. 👍
models.py
Outdated
| 'name_ar': self.arabicBookName, | ||
| 'first_hadith_number': self.firstNumber, | ||
| 'last_hadith_number': self.lastNumber, | ||
| 'total_hadith_number': self.totalNumber |
Contributor
There was a problem hiding this comment.
Let's call this one number_of_narrations instead. And the others narration_start_number and narration_end_number.
Contributor
Author
There was a problem hiding this comment.
@ahadith should I make change the hadith in other places to narration as well. So that. it is consistent?
ahadith
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.