Expose a few functions from tokio::server #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome! It's really nice to get rid of |
sunng87
approved these changes
Oct 21, 2025
Owner
sunng87
left a comment
sunng87
left a comment
There was a problem hiding this comment.
LGTM. Thank you! This is much cleaner
Contributor
Author
|
Would you be able to cut a new release with this? This new version should be backwards-compatible. |
Owner
|
No problem. Released in 0.34.2 |
Contributor
Author
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed well with
git diff --color-moved=zebra --color-moved-ws=ignore-space-change.The first commit splits out parts of
process_socketinto a new functionnegotiate_tls, which callspeek_for_sslrequestand handles setting up the TLS connection. It then exposesnegotiate_tls,process_message, andprocess_erroras public.The second commit inlines
do_process_socketintoprocess_socket, since it no longer needs to be generic over the type of the socket - that's now in theMaybeTlsenum.