feat: release packet size limit for ParameterDescription#418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libpq client side has a limitation on backend message size for 30000 bytes, with a few exceptions like datarow. This
ParameterDescriptionis not in the whitelist, which means it libpq allows at most ~7500 parameters in the message.On the backend side, this is no limitation about the packet size. Some of client drivers, according to my test golang's pgx for example, doesn't enforce the limitation either.
So in this patch, I removed the message length limitation for ParameterDescription so we can support more than 7500 parameters in a statement.