Add a test for ServiceActor::Result#[]#211
Merged
sunny merged 1 commit intosunny:mainfrom Nov 19, 2025
Merged
Conversation
viralpraxis
force-pushed
the
add-a-test-for-service-actor-result-indexed-getter
branch
from
7e1df58 to
ae05eb7
Compare
Currently the `#[]` bypasses the "undefined method warning", but there are no tests for this behaviour. So let's add once to make sure it's not lost
viralpraxis
force-pushed
the
add-a-test-for-service-actor-result-indexed-getter
branch
from
ae05eb7 to
b2d1d61
Compare
viralpraxis
deleted the
add-a-test-for-service-actor-result-indexed-getter
branch
Contributor
Author
|
@sunny by the way, are there any plans on actually raising an error instead of printing a warning? It seems like enough time has passed (and we already had a major bump) |
Owner
|
Yeah I agree that now would be a good time! If you want to have a go at it, please go for it 💪🏻 |
viralpraxis
added a commit
to viralpraxis/actor
that referenced
this pull request
Nov 20, 2025
viralpraxis
added a commit
to viralpraxis/actor
that referenced
this pull request
Nov 20, 2025
viralpraxis
added a commit
to viralpraxis/actor
that referenced
this pull request
Nov 20, 2025
viralpraxis
added a commit
to viralpraxis/actor
that referenced
this pull request
Nov 20, 2025
viralpraxis
added a commit
to viralpraxis/actor
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
#[]bypasses the "undefined method warning", but there are no tests for this behavior