Skip to content

too few braces for f strings to work#52

Merged
nabobalis merged 7 commits into
masterfrom
bugfix
Jan 11, 2021
Merged

too few braces for f strings to work#52
nabobalis merged 7 commits into
masterfrom
bugfix

Conversation

@nabobalis
Copy link
Copy Markdown
Member

@nabobalis nabobalis commented Jan 8, 2021 •
edited
Loading

Description

Fixes #51

@nabobalis nabobalis marked this pull request as ready for review January 8, 2021 09:23
nabobalis
nabobalis commented Jan 8, 2021
View reviewed changes
Comment thread drms/client.py
nabobalis
nabobalis commented Jan 8, 2021
View reviewed changes
Comment thread drms/utils.py
@nabobalis
Copy link
Copy Markdown
Member Author

nabobalis commented Jan 8, 2021

Looking at this example:
https://sunpy--52.org.readthedocs.build/projects/drms/en/52/generated/gallery/export_jpg.html#sphx-glr-generated-gallery-export-jpg-py

The 304 is not returned in the jpg file name and I am unsure if it should be?

Cadair
Cadair approved these changes Jan 8, 2021
View reviewed changes
Comment thread tox.ini Outdated
nabobalis
nabobalis commented Jan 8, 2021
View reviewed changes
Comment thread drms/json.py
nabobalis
nabobalis commented Jan 8, 2021
View reviewed changes
Comment thread drms/json.py
@nabobalis
Copy link
Copy Markdown
Member Author

nabobalis commented Jan 8, 2021

Sunpy failure is known doctest issue.

@nabobalis nabobalis mentioned this pull request Jan 8, 2021
Closed
@wtbarnes
Copy link
Copy Markdown
Member

wtbarnes commented Jan 11, 2021

Sunpy failure is known doctest issue.

I kicked the tests and now I'm getting a different set of failures. Is this still true?

@nabobalis
Copy link
Copy Markdown
Member Author

nabobalis commented Jan 11, 2021

Sunpy failure is known doctest issue.

I kicked the tests and now I'm getting a different set of failures. Is this still true?

Should be.

@nabobalis
Copy link
Copy Markdown
Member Author

nabobalis commented Jan 11, 2021

Looking at this example:
sunpy--52.org.readthedocs.build/projects/drms/en/52/generated/gallery/export_jpg.html#sphx-glr-generated-gallery-export-jpg-py

The 304 is not returned in the jpg file name and I am unsure if it should be?

Open question

@wtbarnes
Copy link
Copy Markdown
Member

wtbarnes commented Jan 11, 2021

Looking at this example:

sunpy--52.org.readthedocs.build/projects/drms/en/52/generated/gallery/export_jpg.html#sphx-glr-generated-gallery-export-jpg-py

The 304 is not returned in the jpg file name and I am unsure if it should be?

Open question

The whole file name format for the jpg export looks different to me than the format for a FITS export

@nabobalis
Copy link
Copy Markdown
Member Author

nabobalis commented Jan 11, 2021

So we can ignore it?

@nabobalis nabobalis merged commit 06da26f into master Jan 11, 2021
@nabobalis nabobalis deleted the bugfix branch January 11, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with downloading FITS files

3 participants

@nabobalis @wtbarnes @Cadair