Skip to content

1.3 plot bugfix #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanRyanIrish merged 3 commits into from
Jul 2, 2020
Merged

1.3 plot bugfix #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e84cfd8
Add changelog for PR #278.
DanRyanIrish Jul 2, 2020
8777e5b
Merge branch '1.3' of https://github.com/sunpy/ndcube into 1.3_plot_b…
DanRyanIrish Jul 2, 2020
e162eb5
Fix plotting bug when dependent axes are not first axes.
DanRyanIrish Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/278.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix NDCube plotting bug when dependent axes are not first axes.
8 changes: 4 additions & 4 deletions ndcube/mixins/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,10 @@ def _derive_axes_coordinates(self, axes_coordinates, axes_units, data_shape, edg
axis_label_text = self.world_axis_physical_types[i]
# If the shape of the data is not 1, or all the axes are not dependent
if new_axis_coordinate.ndim != 1 and new_axis_coordinate.ndim != len(data_shape):
index = utils.wcs.get_dependent_data_axes(self.wcs, i, self.missing_axes)
reduce_axis = np.where(index == np.array([i]))[0]

index = np.delete(index, reduce_axis)
dependent_axes = utils.wcs.get_dependent_data_axes(self.wcs, i,
self.missing_axes)
reduce_axis = np.where(dependent_axes == np.array([i]))[0]
index = np.delete(np.arange(len(dependent_axes)), reduce_axis)
# Reduce the data by taking mean
new_axis_coordinate = np.mean(new_axis_coordinate, axis=tuple(index))

Expand Down