Skip to content

Backport #279#283

Merged
DanRyanIrish merged 5 commits intosunpy:1.3from
DanRyanIrish:1.3_axis_world_coord_values
Aug 4, 2020
Merged

Backport #279#283
DanRyanIrish merged 5 commits intosunpy:1.3from
DanRyanIrish:1.3_axis_world_coord_values

Conversation

@DanRyanIrish
Copy link
Copy Markdown
Member

@DanRyanIrish DanRyanIrish commented Jul 30, 2020

Description

Backport PR #279 to the 1.3 branch, adding new method NDCube.axis_world_coord_values.

Depends on backport PR #282. DO NOT MERGE UNTIL THAT'S MERGE.

Fixes #

@DanRyanIrish DanRyanIrish force-pushed the 1.3_axis_world_coord_values branch from 26d2826 to 6f7a87b Compare July 30, 2020 15:22
@DanRyanIrish DanRyanIrish changed the title 1.3 axis world coord values Backport #279 Jul 30, 2020
…en sliced by making it use wcs.pixel_to_world_values and inserting dummy axes in for missing axes.
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Aug 3, 2020

Hello @DanRyanIrish! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 276:17: E127 continuation line over-indented for visual indent

Line 604:101: E501 line too long (130 > 100 characters)

Comment last updated at 2020-08-04 10:29:27 UTC

@DanRyanIrish DanRyanIrish merged commit ded1813 into sunpy:1.3 Aug 4, 2020
Cadair added a commit to Cadair/ndcube that referenced this pull request Oct 13, 2020
…_coord_values"

This reverts commit ded1813, reversing
changes made to c0c4747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants