Skip to content

Backport 1.3: Change name of Spectrogram.axis_world_coord_values#292

Merged
DanRyanIrish merged 3 commits intosunpy:1.3from
DanRyanIrish:1.3_axis_world_coord_values
Oct 9, 2020
Merged

Backport 1.3: Change name of Spectrogram.axis_world_coord_values#292
DanRyanIrish merged 3 commits intosunpy:1.3from
DanRyanIrish:1.3_axis_world_coord_values

Conversation

@DanRyanIrish
Copy link
Copy Markdown
Member

@DanRyanIrish DanRyanIrish commented Oct 6, 2020

Change to Spectrogram.axis_world_coords_values to make it consistent with Spectrogram.axis_world_coords. This PR backports the changes from #293 to the 1.3 branch.

@DanRyanIrish DanRyanIrish changed the title Change method name to axis_world_coords_values. 1.3: Change name of Spectrogram.axis_world_coords Oct 6, 2020
@DanRyanIrish DanRyanIrish changed the title 1.3: Change name of Spectrogram.axis_world_coords 1.3: Change name of Spectrogram.axis_world_coord_values Oct 6, 2020
@DanRyanIrish DanRyanIrish requested a review from Cadair October 6, 2020 13:41
@DanRyanIrish
Copy link
Copy Markdown
Member Author

sunpy dev tests fail ue #288 and codestyle fails because of specific pre-existing issue beyond scope of this PR.

@DanRyanIrish DanRyanIrish force-pushed the 1.3_axis_world_coord_values branch from c5c529f to dfc4035 Compare October 9, 2020 13:08
@DanRyanIrish DanRyanIrish changed the title 1.3: Change name of Spectrogram.axis_world_coord_values Backport 1.3: Change name of Spectrogram.axis_world_coord_values Oct 9, 2020
@DanRyanIrish DanRyanIrish force-pushed the 1.3_axis_world_coord_values branch from cc71d77 to 262907c Compare October 9, 2020 13:44
@DanRyanIrish DanRyanIrish merged commit 72a1b11 into sunpy:1.3 Oct 9, 2020
Cadair added a commit to Cadair/ndcube that referenced this pull request Oct 13, 2020
…_coord_values"

This reverts commit 72a1b11, reversing
changes made to f16faab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant