Move ImageAnimatorWCS into ndcube from sunpy.#306
Merged
Conversation
DanRyanIrish
force-pushed
the
1.4_transfer_imageanimatorwcs
branch
2 times, most recently
from
6b8f8d3 to
1e86162
Compare
DanRyanIrish
changed the title
Member
Author
Member
|
are there tests to pull over? |
DanRyanIrish
force-pushed
the
1.4_transfer_imageanimatorwcs
branch
from
1e86162 to
dcf994b
Compare
Member
Author
No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
ImageAnimatorWCSinto the ndcube 1.4 branch from sunpy where it is no longer supported from sunpy 2.1 onwards.ndcube 2.0 will use sunpy's
ArrayAnimatorWCSas part of a major plotting refactor. Therefore, the presence ofImageAnimatorWCSin ndcube is a temporary fix for the remainder of the 1.x versions.