Deprecate world_axis_physical_types properties#309
Merged
DanRyanIrish merged 4 commits intosunpy:1.4from Nov 3, 2020
Merged
Conversation
|
Hello @DanRyanIrish! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-03 12:30:25 UTC |
in favor of array_axis_physical_types properties. This required new such properties to be added to NDCubeSequence. The world_axis_physical_types properties will be removed in 2.0
DanRyanIrish
force-pushed
the
1.4_deprecate_physical_types
branch
from
b936723 to
b4cc180
Compare
Cadair
reviewed
Nov 3, 2020
Comment on lines
+227
to
+229
| message='NDCube.world_axis_physical_types will be removed in version 2.0. ' + \ | ||
| 'Use NDCube.wcs.world_axis_physical_types or ' + \ | ||
| 'NDCube.array_axis_physical_types instead.') |
Member
There was a problem hiding this comment.
you don't need line continuation inside brackets, or +.
Suggested change
| message='NDCube.world_axis_physical_types will be removed in version 2.0. ' + \ | |
| 'Use NDCube.wcs.world_axis_physical_types or ' + \ | |
| 'NDCube.array_axis_physical_types instead.') | |
| message=('NDCube.world_axis_physical_types will be removed in version 2.0. ' | |
| 'Use NDCube.wcs.world_axis_physical_types or ' | |
| 'NDCube.array_axis_physical_types instead.')) |
Cadair
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in favor of array_axis_physical_types properties. This required new properties to be added to NDCubeSequence. The world_axis_physical_types properties will be removed in 2.0