Improve metadata handling in spectrogram sources and add safety tests#178
Open
tejasnarwade wants to merge 5 commits intosunpy:mainfrom
Open
Improve metadata handling in spectrogram sources and add safety tests#178tejasnarwade wants to merge 5 commits intosunpy:mainfrom
tejasnarwade wants to merge 5 commits intosunpy:mainfrom
Conversation
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the robustness of spectrogram source detection by handling cases where metadata keys may be missing.
What was the issue?
Some
is_datasource_forimplementations accessed metadata using direct dictionary indexing (e.g.,meta["instrument"]).This caused a
KeyErrorwhen the metadata dictionary did not contain those keys.What changes were made?
.get()usage in:test_metadata_safety.py) to ensure that all relevant spectrogram sources:Why this matters
This makes the code more robust when working with incomplete or unexpected metadata, which can occur in real-world data scenarios.
Additional Notes
While adding the test, it revealed that some sources were not handling missing metadata correctly.
This PR fixes those inconsistencies and ensures uniform behavior across sources.
Testing
PR Description
AI tools were used for: