Bugfix ecallisto client #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Oct 31, 2021
nabobalis
reviewed
Oct 31, 2021
nabobalis
reviewed
Oct 31, 2021
Member
Author
|
So essentially from the filename alone there's no way to tell about either the frequency or duration (see #60) so I think only returning only a start time makes sense and having no frequency information also makes sense. Can be documented in the client maybe. Long term really need all those fits files to be indexed into some database and then search that but that's beyond the scope of radiospectra 😂 |
nabobalis
force-pushed
the
bugfix-ecallisto-client
branch
from
645fc5d to
1852b59
Compare
nabobalis
force-pushed
the
bugfix-ecallisto-client
branch
from
bfacc0e to
0b09cd5
Compare
nabobalis
force-pushed
the
bugfix-ecallisto-client
branch
from
0b09cd5 to
6e93300
Compare
nabobalis
force-pushed
the
bugfix-ecallisto-client
branch
from
a1e0caf to
ab0d29a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11 and the eCallisto client now returns all data the archive and removed the end time attribute see #60