Skip to content

Update maturin#140

Merged
Cadair merged 1 commit into
sunpy:mainfrom
Cadair:update_maturin
May 8, 2024
Merged

Update maturin#140
Cadair merged 1 commit into
sunpy:mainfrom
Cadair:update_maturin

Conversation

@Cadair
Copy link
Copy Markdown
Member

@Cadair Cadair commented May 8, 2024

I just keep finding things to do

@Cadair Cadair requested a review from nabobalis May 8, 2024 14:42
Comment thread pyproject.toml
Comment thread Cargo.toml
name = "streamtracer"
version = "2.0.1"
version = "2.1.0"
edition = "2021"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need updating?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly am not sure what this version is actually used for, but I guess it should be in sync with the one in pyproject for good measure. I will update and do a rc2 shortly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google says:

The edition key is an optional key that affects which Rust Edition your package is compiled with. Setting the edition key in [package] will affect all targets/crates in the package, including test suites, benchmarks, binaries, examples, etc.

Most manifests have the edition field filled in automatically by cargo new with the latest stable edition. By default cargo new creates a manifest with the 2021 edition currently.

If the edition field is not present in Cargo.toml, then the 2015 edition is assumed for backwards compatibility. Note that all manifests created with cargo new will not use this historical fallback because they will have edition explicitly specified to a newer value.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should leave it as 2021, the new version 2024 is under progress.

@Cadair Cadair merged commit 7d34555 into sunpy:main May 8, 2024
@Cadair Cadair deleted the update_maturin branch May 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants