Store ASDA test data as FITS files rather than npz#301
Merged
Cadair merged 14 commits intosunpy:mainfrom Feb 18, 2026
Merged
Conversation
nabobalis
approved these changes
Feb 12, 2026
Cadair
reviewed
Feb 18, 2026
| tests = [ | ||
| "sunkit_image[all]", | ||
| "dask", | ||
| # NumPy>=2.4 not compatible with some helpers in astropy<7.2 |
Member
There was a problem hiding this comment.
This feels like a bad idea? What was the beef?
Cadair
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295
I had to bypass the large file check on precommit, but the FITS file added was the same size as the npz file deleted. The other file is actually smaller as I pruned the file to include the data needed for the tests.