Skip to content

Conversation

@nabobalis
Copy link
Member

@nabobalis nabobalis commented Mar 25, 2020

Backports #3838 and #3899 and #3852 and #3917

Also will check the CI.

Cadair and others added 3 commits March 25, 2020 19:53
updated HEKClient to return json again
fix issue with 'as-is' protocol and add support for pathlib in JSOCClient
@nabobalis nabobalis added the No Changelog Entry Needed Skip all changelog checks. label Mar 25, 2020
@nabobalis nabobalis added this to the 1.0.9 milestone Mar 25, 2020
@pep8speaks
Copy link

pep8speaks commented Mar 25, 2020

Hello @nabobalis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 417:18: E127 continuation line over-indented for visual indent
Line 418:38: E128 continuation line under-indented for visual indent
Line 419:38: E128 continuation line under-indented for visual indent
Line 420:38: E128 continuation line under-indented for visual indent
Line 421:38: E128 continuation line under-indented for visual indent
Line 422:38: E128 continuation line under-indented for visual indent
Line 423:38: E128 continuation line under-indented for visual indent
Line 424:38: E128 continuation line under-indented for visual indent
Line 425:38: E128 continuation line under-indented for visual indent

Line 343:101: E501 line too long (114 > 100 characters)

Line 36:34: E231 missing whitespace after ','

Line 416:1: E302 expected 2 blank lines, found 1

Line 173:101: E501 line too long (108 > 100 characters)

Comment last updated at 2020-03-25 23:27:13 UTC

@wtbarnes wtbarnes merged commit 7fe3810 into sunpy:1.0 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Entry Needed Skip all changelog checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants