Merged
Conversation
Member
Author
|
@Cadair, you might be interested in discussing this as I think it has potential implications for sunpy. |
Cadair
reviewed
Jul 23, 2020
sunraster/meta/meta.py
Outdated
| @@ -0,0 +1,52 @@ | |||
| __all__ = ["RemoteSensorMetaABC", "SlitSpectrographMetaABC"] | |||
|
|
|||
| class RemoteSensorMetaABC(): | |||
Member
There was a problem hiding this comment.
you should make this an actual ABC and use abstract method on the properties.
Cadair
reviewed
Jul 23, 2020
sunraster/meta/meta.py
Outdated
| pass | ||
|
|
||
| @property | ||
| def date(self): |
Member
There was a problem hiding this comment.
date is probably not a good key, something likeobservation_date or even better date_start date_end would map better to FITS and sanity.
Cadair
reviewed
Jul 23, 2020
sunraster/meta/meta.py
Outdated
| pass | ||
|
|
||
| @property | ||
| def dsun(self): |
Cadair
reviewed
Jul 23, 2020
sunraster/meta/meta.py
Outdated
| pass | ||
|
|
||
| @property | ||
| def rsun_obs(self): |
Member
There was a problem hiding this comment.
this is just FITS, not sure what's better though.
Cadair
reviewed
Jul 23, 2020
sunraster/meta/spice.py
Outdated
| __all__ = ["SPICEMeta"] | ||
|
|
||
|
|
||
| class SPICEMeta(fits.header.Header, SlitSpectrographMetaABC): |
Member
There was a problem hiding this comment.
I am not sure inherting from fits header is wise, it might be better long term to keep the header as an attribute rather than actually this object.
DanRyanIrish
force-pushed
the
spice
branch
3 times, most recently
from
59758c6 to
73240c5
Compare
Remove SPICEMeta inheritance of astropy FITS header. Rename some metadata property names to be more descriptive.
Member
Author
|
@Cadair, does this now provide the features you were looking for? |
DanRyanIrish
force-pushed
the
spice
branch
2 times, most recently
from
8894add to
dbb64fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces metadata objects that define a standard API for accessing commonly used solar metadata for slit spectrograph instruments. It includes a specific implementation for SolO/SPICE.