Skip to content

Conversation

@FatumaA
Copy link
Collaborator

@FatumaA FatumaA commented Jan 8, 2024

What kind of change does this PR introduce?

Add native Google and Apple sign in support
Closes #60

What is the current behavior?

No simple native support

What is the new behavior?

Adds support

@FatumaA FatumaA marked this pull request as draft January 8, 2024 22:16
@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 8, 2024

Hey @dshukertjr,
This is a first attempt at adding google and apple native auth.
I cant test iOS on my end. The google one seems to work as expected.

Please take a look and also test iOS if poss.

Thank you.

@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 22, 2024

Hi @dshukertjr ,
I think this is ready for testing but could do with some clean up.
Have a look and lmk

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I haven't tested it yet, but will do in the morning! Thanks for the amazing work 💪

@dshukertjr dshukertjr marked this pull request as ready for review January 23, 2024 07:15
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and it works like a charm. Let's merge it whenever you are happy with it!

@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 25, 2024

I tested it, and it works like a charm. Let's merge it whenever you are happy with it!

I think we can merge then

@dshukertjr dshukertjr merged commit a20501f into supabase-community:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add native Apple and Google sign in for iOS and Android

2 participants