feat: prepare for renaming to postgres-language-server
#52
Conversation
juleswritescode
changed the title
postgres-language-server
psteinroe
left a comment
psteinroe
left a comment
There was a problem hiding this comment.
maybe we can get rid of the constants and do it dynamically? we dont have to commit to certain versions then…
src/downloader.ts
Outdated
| ); | ||
|
|
||
| const url = newNameAvailable | ||
| ? `https://github.com/supabase-community/postgres_lsp/releases/download/${version}/${CONSTANTS.newPlatformSpecificReleasedAssetName}` |
There was a problem hiding this comment.
the repo name is postgres-language-server
There was a problem hiding this comment.
ah yes, you're right. (JFYI the old link also works)
src/downloader.ts
Outdated
| const url = `https://github.com/supabase-community/postgres_lsp/releases/download/${version}/${CONSTANTS.platformSpecificReleasedAssetName}`; | ||
| const newNameAvailable = semver.gte( | ||
| version, | ||
| EARLIEST_CROSS_PUBLISHING_RELEASE |
There was a problem hiding this comment.
can't we run a HEAD request and really just try if the new binary is there, else use the old one? not a huge fan of the constant
great idea! I made it a bit simpler. We'll now check if the new binary is available and if so add a little "please use the other binary name" to the existing "your postgrestools version is outdated" message. Note: Users that are on the most recent version will only get this message in about 3 versions. I'll test this once the new assets are released on npm etc. and then I'll release it 👍🏻 |
No description provided.