Skip to content

avoid building skipped tests vector in every loop #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

avoid building skipped tests vector in every loop #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/pg_syntax/tests/pg_syntax_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const SNAPSHOTS_PATH: &str = "snapshots/data";
#[test]
fn valid_statements() {
// dont do postgres regress tests for now
let skipped_tests: Vec<_> = SKIPPED_REGRESS_TESTS.lines().collect();

for path in [VALID_STATEMENTS_PATH] {
let mut paths: Vec<_> = fs::read_dir(path).unwrap().map(|r| r.unwrap()).collect();
paths.sort_by_key(|dir| dir.path());
Expand All @@ -23,11 +25,7 @@ fn valid_statements() {
let path = f.path();
let test_name = path.file_stem().unwrap().to_str().unwrap();

if SKIPPED_REGRESS_TESTS
.lines()
.collect::<Vec<_>>()
.contains(&test_name)
{
if skipped_tests.contains(&test_name) {
continue;
}

Expand Down
Loading