feat(config): add connectionString #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
love it, maybe this is a good opportunity to also finish #302 ?
yeah, it could be as simple as adding a ENV to the cli option |
# Conflicts: # crates/pgt_cli/tests/commands/check.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
connectionStringto the database config. if provided, it is preferred over the individualhost,port, etc. settings.note that the
ConnectionKeystill checks only based on the basic infos. This could potentially lead to an issue if the same workspace instance accepts multiple connections to the same database. if one is e.g. adding differentsslmodesettings via the connection sring, it would be re-used even if another just has the samehost+port+user+database. I do not think we need to distinguish here since that case should not really happen unless you host this as a service that is shared among many people.fixes #575