refractor(splinter): allow non-supabase rules to run always #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove empty line after outer attribute in pgls_diagnostics - Replace useless format! with .to_string() in pgls_splinter - Refactor loops to use .enumerate() and slice indexing in xtask_codegen - Add clippy and git commit guidelines to AGENTS.md
juleswritescode
approved these changes
Nov 7, 2025
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
very cool! i like how you integrated this into the LSP!
|
|
||
| let results = query::load_splinter_results(params.conn).await?; | ||
| // Only run Supabase-specific rules if the required roles exist | ||
| let has_supabase_roles = check_supabase_roles(params.conn).await?; |
Collaborator
There was a problem hiding this comment.
nice! curious: did the supabase team confirm that this check is the best way to identify a supabase database?
Collaborator
Author
There was a problem hiding this comment.
nope, but for squawk this is what is required to exist for the rules query to not crash :D
| result | ||
| } | ||
|
|
||
| fn split_queries(content: &str) -> (String, String) { |
Collaborator
There was a problem hiding this comment.
as I understand it, rules are per default put into the generic category.
what happens if supabase adds a new rule to the spliter that's supabase-specific?
that might break linting in case a table isn't defined for non-supabase databases, right?
should we throw during build if there's an unknown rule in the splinter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manually splits the
splinter.sqlfile into generic and supabase-only rules during download inbuild.rs.based on the existence of the roles, run either one or both.
also improved the url handling - no manual fix needed anymore.