fix: take care of should_create_user when using LoginEmailOtpParams
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoginMobileOtpParams
Collaborator
|
Thanks David! The contribution is much appreciated. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, to not create a user when otp's options have
should_create_user = Some(false)What is the current behavior?
Calling
send_email_with_otpalways creates a user in the database, regardless of theshould_create_usersetting.What is the new behavior?
An error is returned when
should_create_user = Some(false)on a new email.Additional context
The js/ts API doesn't match the OpenAPI on the endpoint
/otp. Not justshould_create_user, I guess thatemail_redirect_toandcaptcha_tokenare currently useless.