This repository was archived by the owner on Oct 10, 2025. It is now read-only.
chore: refactor #252
Merged
chore: refactor #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorwebdev
commented
Mar 19, 2022
Comment on lines
+201
to
+202
| export type MobileOTPType = 'sms' | ||
| export type EmailOTPType = 'signup' | 'invite' | 'magiclink' | 'recover' | 'email_change' |
There was a problem hiding this comment.
@kangmingtay can you double check that this separation is correct?
There was a problem hiding this comment.
hmm seems like it should be 'recovery' instead of 'recover' (https://github.com/supabase/gotrue/blob/master/api/verify.go#L24)
kangmingtay
suggested changes
Mar 20, 2022
Comment on lines
+201
to
+202
| export type MobileOTPType = 'sms' | ||
| export type EmailOTPType = 'signup' | 'invite' | 'magiclink' | 'recover' | 'email_change' |
There was a problem hiding this comment.
hmm seems like it should be 'recovery' instead of 'recover' (https://github.com/supabase/gotrue/blob/master/api/verify.go#L24)
kangmingtay
approved these changes
Mar 20, 2022
|
🎉 This PR is included in version 1.22.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kangmingtay I've refactored the types and simplified the api and client a bit.
With the types like this,
typeis optional when providingphonebut is required when providingemail👍