This repository was archived by the owner on Sep 8, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 53
Bring closer to pairity with supabase/gotrue-js #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedden
commented
Feb 14, 2021
Collaborator
Author
fedden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J0 let me know what you think!
J0
approved these changes
Feb 16, 2021
Contributor
J0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this!
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
Collaborator
Author
|
Okay @J0 I've addressed all PR comments - thanks for leaving the review. Merge when you are ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of tests
More closely matches the structure of the js library, which will help us keep on top of future changes.