Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@fedden
Copy link
Collaborator

@fedden fedden commented Feb 13, 2021

Adds a bunch of tests
More closely matches the structure of the js library, which will help us keep on top of future changes.

Copy link
Collaborator Author

@fedden fedden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0 let me know what you think!

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

fedden and others added 5 commits February 16, 2021 09:15
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
Co-authored-by: Lee Yi Jie Joel <lee.yi.jie.joel@gmail.com>
@fedden
Copy link
Collaborator Author

fedden commented Feb 16, 2021

Okay @J0 I've addressed all PR comments - thanks for leaving the review. Merge when you are ready

@J0 J0 merged commit 38eddcb into supabase:main Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants