This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Use poetry for dependency and environment management #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove requirements.txt and setup.py
J0
reviewed
Oct 13, 2021
|
|
||
| This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, | ||
| available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html | ||
| available at <https://www.contributor-covenant.org/version/1/4/code-of-conduct.html> |
Contributor
There was a problem hiding this comment.
Just curious, what's the purpose of wrapping in < and >?
Contributor
Author
There was a problem hiding this comment.
Oh yup, it is that I use the VS Code extension for Markdown files and it has a rule for links without <>
Extension: https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
Rule: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md034---bare-url-used
The extension follows the specifications of https://commonmark.org
Contributor
There was a problem hiding this comment.
Okay, thanks for the explanation.
J0
approved these changes
Oct 13, 2021
Contributor
J0
left a comment
J0
left a comment
There was a problem hiding this comment.
LGTM, just one question/nit about modifications to the Code of Conduct.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #18