Add dataclasses, sync/async, feature-parity with the js-client and tests #23

leynier · 2021-10-14T18:17:30Z

To Do:

Implement types with dataclasses
Implement sync/async support with httpx and unasync
Add pre-commit config to force Pythonic style
Synchronize implementation of GoTrueApi with the implementation of gotrue-js
Synchronize implementation of GoTrueClient with the implementation of gotrue-js
Synchronize tests implementation with the tests of gotrue-js

Tests:

apiWithAutoConfirmDisabled.test.ts
clientWithAutoConfirmDisabled.test.ts
clientWithAutoConfirmEnabled.test.ts
clientWithSignupsDisabled.test.ts
provider.test.ts
subscriptions.test.ts

Issues:

Fix #9
Fix #10
Fix #15
Fix #17
Fix #20
Fix #21
Fix #22
Fix supabase/supabase-py#70

Notes

The _sync folders are generated automatically with the make build_sync command.
All scripts in the _async folders will be translated into their synchronous form using unasync behind the scenes.
The set_auth_cookie and get_user_by_cookie methods of API later I don't think it still makes sense to have them in the Python library.

…torage

The "_sync" folder is generated automatically with the "make build_sync" command. All scripts in the "_async" folder will be translated into their synchronous form using "unasync" behind the scenes.

leynier · 2021-11-16T15:42:54Z

@leynier could you add the default x-header that #11 does, since that PR is done with the old version of this library, please?

I will do it right now 👍🏼

J0 · 2021-11-16T17:50:33Z

@leynier will do!

dreinon · 2021-11-16T17:53:00Z

What's dev container for @leynier ?

leynier · 2021-11-16T17:54:03Z

What's dev container for @leynier ?

https://code.visualstudio.com/docs/remote/devcontainerjson-reference

leynier · 2021-11-16T17:56:09Z

What's dev container for @leynier ?

It will make collaboration easier by defining a common sandbox for all developers among other things. It is not required to use, it is the decision of each dev at the end.

dreinon · 2021-11-16T18:00:46Z

@J0 @anand2312 approve changes whenever you are done reviewing and we'll merge!

anand2312

LGTM; minor typo to be fixed

README.md

Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>

sourcery-ai · 2021-11-17T09:20:35Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 1.57%.

Quality metrics	Before	After	Change
Complexity	2.55 ⭐	4.48 ⭐	1.93 👎
Method Length	36.68 ⭐	34.60 ⭐	-2.08 👍
Working memory	5.80 ⭐	6.33 🙂	0.53 👎
Quality	83.02% ⭐	81.45% ⭐	-1.57% 👎

Other metrics	Before	After	Change
Lines	733	91	-642

Changed files	Quality Before	Quality After	Quality Change
conftest.py	71.24% 🙂	71.16% 🙂	-0.08% 👎
docs/source/conf.py	97.17% ⭐	97.17% ⭐	0.00%
gotrue/init.py	100.00% ⭐	94.35% ⭐	-5.65% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
conftest.py	pytest_runtest_makereport	7 ⭐	53 ⭐	11 😞	67.21% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai · 2021-11-17T09:20:36Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 1.57%.

Quality metrics	Before	After	Change
Complexity	2.55 ⭐	4.48 ⭐	1.93 👎
Method Length	36.68 ⭐	34.60 ⭐	-2.08 👍
Working memory	5.80 ⭐	6.33 🙂	0.53 👎
Quality	83.02% ⭐	81.45% ⭐	-1.57% 👎

Other metrics	Before	After	Change
Lines	733	91	-642

Changed files	Quality Before	Quality After	Quality Change
conftest.py	71.24% 🙂	71.16% 🙂	-0.08% 👎
docs/source/conf.py	97.17% ⭐	97.17% ⭐	0.00%
gotrue/init.py	100.00% ⭐	94.35% ⭐	-5.65% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
conftest.py	pytest_runtest_makereport	7 ⭐	53 ⭐	11 😞	67.21% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

dreinon · 2021-11-17T10:59:32Z

@leynier do you think sourcery could be added to pre-commit hooks? It was added yesterday in the postgrest-py library.

repos:
  - repo: https://github.com/sourcery-ai/sourcery
    rev: v0.8.0 # Get the latest tag from https://github.com/sourcery-ai/sourcery/tags
    hooks:
      - id: sourcery
      # - args: [--in-place]  Automatically apply the refactorings in the hook

leynier · 2021-11-17T13:29:47Z

@leynier do you think sourcery could be added to pre-commit hooks? It was added yesterday in the postgrest-py library.
repos:
  - repo: https://github.com/sourcery-ai/sourcery
    rev: v0.8.0 # Get the latest tag from https://github.com/sourcery-ai/sourcery/tags
    hooks:
      - id: sourcery
      # - args: [--in-place]  Automatically apply the refactorings in the hook

I think it is not a good idea to add it as a pre-commit hook. Because I did the test by adding the hooks, that asked me for a login token, create the account and I log in, to log in I had to add sourcery-cli to the development dependencies and finally, I get this error.

I think it should just stay as a GitHub app associated with the repository and suggest changes to pull requests.

leynier · 2021-11-17T13:31:15Z

@leynier do you think sourcery could be added to pre-commit hooks? It was added yesterday in the postgrest-py library.
repos:
  - repo: https://github.com/sourcery-ai/sourcery
    rev: v0.8.0 # Get the latest tag from https://github.com/sourcery-ai/sourcery/tags
    hooks:
      - id: sourcery
      # - args: [--in-place]  Automatically apply the refactorings in the hook
I think it is not a good idea to add it as a pre-commit hook. Because I did the test by adding the hooks, that asked me for a login token, create the account and I log in, to log in I had to add sourcery-cli to the development dependencies and finally, I get this error.

I think it should just stay as a GitHub app associated with the repository and suggest changes to pull requests.

The same will happen with the postgrest-py repository, I also think that we should remove it from the hooks in that repository.

sourcery-ai · 2021-11-17T13:42:06Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 1.57%.

Quality metrics	Before	After	Change
Complexity	2.55 ⭐	4.48 ⭐	1.93 👎
Method Length	36.68 ⭐	34.60 ⭐	-2.08 👍
Working memory	5.80 ⭐	6.33 🙂	0.53 👎
Quality	83.02% ⭐	81.45% ⭐	-1.57% 👎

Other metrics	Before	After	Change
Lines	733	91	-642

Changed files	Quality Before	Quality After	Quality Change
conftest.py	71.24% 🙂	71.16% 🙂	-0.08% 👎
docs/source/conf.py	97.17% ⭐	97.17% ⭐	0.00%
gotrue/init.py	100.00% ⭐	94.35% ⭐	-5.65% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
conftest.py	pytest_runtest_makereport	7 ⭐	53 ⭐	11 😞	67.21% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

angrycaptain19 · 2021-11-17T15:27:31Z

@leynier

Hey @leynier - sorry about this! I'm from the Sourcery team and we've rolled out the pre-commit option fairly recently. It's usually a part of our paid Team tier, but we definitely want it to be available for use for free for open source projects. I just gave you access to it, so it should now fully work if you wanted to try it out.

If you've got any feedback for us about the pre-commit hook or Sourcery more generally that would be incredibly helpful.

Thanks!

PS: @dreinon - I also gave you access to the pre-commit hook functionality

dreinon · 2021-11-17T15:55:15Z

@angrycaptain19 thank you, we appreciate it! Nevertheless, we would need you to provide free access to any contributor that wants to submit a PR to our libraries without explicitly providing free access to their account, which wouldn't make sense since anyone would have free access to the hook by cloning the libs. Therefore, in my opinion, we still wouldn't be interested in adding the hook. Correct me if I'm wrong 😊

sourcery-ai · 2021-11-17T18:34:24Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 1.57%.

Quality metrics	Before	After	Change
Complexity	2.55 ⭐	4.48 ⭐	1.93 👎
Method Length	36.68 ⭐	34.60 ⭐	-2.08 👍
Working memory	5.80 ⭐	6.33 🙂	0.53 👎
Quality	83.02% ⭐	81.45% ⭐	-1.57% 👎

Other metrics	Before	After	Change
Lines	733	91	-642

Changed files	Quality Before	Quality After	Quality Change
conftest.py	71.24% 🙂	71.16% 🙂	-0.08% 👎
docs/source/conf.py	97.17% ⭐	97.17% ⭐	0.00%
gotrue/init.py	100.00% ⭐	94.35% ⭐	-5.65% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
conftest.py	pytest_runtest_makereport	7 ⭐	53 ⭐	11 😞	67.21% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

J0

I think this looks great! Am looking forward to the new release :) Feel free to merge whenever ready.

J0 · 2021-11-18T08:33:20Z

@leynier I couldn't quite find you on Discord but we would like to check if you'd be interested in becoming a maintainer of Gotrue-py. Let us know!

Alternatively, if you'd like to chat in private feel free to ping me at @J0 or @dreinon on Discord. Think both our handles.

leynier added 3 commits October 14, 2021 14:14

feat: implement dataclasses with methods for parsing

82d1d6c

feat: add new types, implement to_dicts and align files with gotrue-js

25e223b

feat: add types to API class and align implementation with gotrue-js

1ed9754

leynier mentioned this pull request Oct 17, 2021

Use provided JWT to make supabase client object logged with this JWT supabase/supabase-py#70

Closed

leynier added 13 commits October 17, 2021 00:35

chore: formatting code

f9ff600

feat: implement CookieOptions type

930273f

feat: implement AuthChangeEvent enum

a6dacaf

feat: implement Subscription type

8c64876

feat: implement SupportedStorage abstract storage and MemoryStorage s…

044efe8

…torage

feat: add CookieOptions to constructor of GoTrueApi

4ef1b55

feat: synchronize implementation of GoTrueClient

0a669de

chore: format conftest.py

3400431

feat: add poetry to CI action and add dependabot config file

ee916c2

chore: fix name of ci test job

112ce71

chore: change order of strategy parameter

ae0ba3f

chore: fix name of ci test job

2ac3930

feat: implement sync/async support with httppx and unasync

da10e87

The "_sync" folder is generated automatically with the "make build_sync" command. All scripts in the "_async" folder will be translated into their synchronous form using "unasync" behind the scenes.

leynier changed the title ~~Response dataclasses models instead of dicts~~ Add dataclasses to responses, sync/async support, feature-parity with the js-client and tests Oct 17, 2021

leynier changed the title ~~Add dataclasses to responses, sync/async support, feature-parity with the js-client and tests~~ Add dataclasses, sync/async, feature-parity with the js-client and tests Oct 17, 2021

leynier added 11 commits October 17, 2021 17:34

feat: add context manager support

42619ea

chore: add doc to on_auth_state_change

267c62c

chore: format code of sync client

bfc5fab

feat: add pre-commit system for check Pythonic style

09f9b47

chore: regenerate sync client

8ddd940

chore: format code by pre-commit

2fbcb70

feat: add Make rule for infra

6ac5334

chore: add dependencies for code coverage and fix tests command

3ab70a5

fix: cycle of references between helpers and types

fcad1af

chore: separate tests rule in multiples rules

5815566

fix: error in remove_item of memory storage

9c12bd1

leynier added 4 commits November 16, 2021 17:19

feat: add X-Client-Info to default headers

ec2c893

chore: update dependencies

83e8f5e

fix: remove duplicate var env in docker-compose.yml

6e501c9

feat: add devcontainer.json for use github codespaces

0e78b62

docs: update some info of readme

20235fe

dreinon mentioned this pull request Nov 16, 2021

added default header value #11

Closed

anand2312 approved these changes Nov 17, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

Fix typo in README.md

ec0bdb5

Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>

chore: remove unused noqa comment

fdc6318

dreinon mentioned this pull request Nov 17, 2021

Add Sourcery to pre-commit supabase/postgrest-py#38

Merged

Switch isort mirror by isort pre-commit hook

427d5d4

J0 approved these changes Nov 18, 2021

View reviewed changes

dreinon merged commit fb10c5c into supabase:main Nov 18, 2021

leynier deleted the feat/dataclasses branch November 18, 2021 12:33

Uh oh!

Add dataclasses, sync/async, feature-parity with the js-client and tests #23

Add dataclasses, sync/async, feature-parity with the js-client and tests #23

Uh oh!

Conversation

leynier commented Oct 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To Do:

Tests:

Issues:

Notes

Uh oh!

leynier commented Nov 16, 2021

Uh oh!

J0 commented Nov 16, 2021

Uh oh!

dreinon commented Nov 16, 2021

Uh oh!

leynier commented Nov 16, 2021

Uh oh!

leynier commented Nov 16, 2021

Uh oh!

dreinon commented Nov 16, 2021

Uh oh!

anand2312 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sourcery-ai bot commented Nov 17, 2021

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

sourcery-ai bot commented Nov 17, 2021

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

dreinon commented Nov 17, 2021

Uh oh!

leynier commented Nov 17, 2021

Uh oh!

leynier commented Nov 17, 2021

Uh oh!

sourcery-ai bot commented Nov 17, 2021

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

angrycaptain19 commented Nov 17, 2021

Uh oh!

dreinon commented Nov 17, 2021

Uh oh!

sourcery-ai bot commented Nov 17, 2021

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

J0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

J0 commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

leynier commented Oct 14, 2021 •

edited

Loading

J0 left a comment •

edited

Loading