Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@lmoj
Copy link
Contributor

@lmoj lmoj commented May 15, 2023

#246

urlencode calls quote on params

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03 🎉

Comparison is base (736f334) 37.59% compared to head (034da90) 37.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   37.59%   37.62%   +0.03%     
==========================================
  Files          25       25              
  Lines        2285     2283       -2     
==========================================
  Hits          859      859              
+ Misses       1426     1424       -2     
Impacted Files Coverage Δ
gotrue/_async/gotrue_client.py 30.17% <50.00%> (+0.07%) ⬆️
gotrue/_sync/gotrue_client.py 30.17% <50.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lmoj
Copy link
Contributor Author

lmoj commented May 24, 2023

@J0 calling supabase.auth.sign_in_with_oauth({'provider': 'google', 'options': {'redirect_to': 'http://localhost:3000'}}) returns OAuthResponse(provider='google', url='https://xxx.supabase.co/auth/v1/authorize?redirect_to=http%253A%2F%2Flocalhost%253A3000&provider=google'), is broken

@J0 J0 merged commit dca7d9a into supabase:main May 25, 2023
@J0
Copy link
Contributor

J0 commented May 25, 2023

Thanks for flagging and also filing the PR - will do another test when a slot frees up and then publish a new version

@0xDeadcell
Copy link

@J0 when might we expect a release with this fix in a new version?

@J0
Copy link
Contributor

J0 commented Jun 1, 2023

Just published GoTrue-py, Supabase-py will probably come within the week

@0xDeadcell
Copy link

Thanks @J0, any updates on this?

@lmoj lmoj deleted the double-urlencode branch June 20, 2023 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants