Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@leynier
Copy link
Contributor

@leynier leynier commented Nov 19, 2021

Resolve #30
Resolve #31

@codecov-commenter

This comment was marked as off-topic.

@leynier leynier marked this pull request as draft November 20, 2021 00:09
@leynier leynier force-pushed the feat/add-pre-commit-hook-for-conventional-commit branch from 8cd7b33 to 2f6bcf2 Compare November 20, 2021 00:55
@leynier leynier changed the title feat: add pre-commit hook for conventional commit feat: add pre-commit hook and action for conventional commit and semantic release Nov 20, 2021
@leynier leynier marked this pull request as ready for review November 20, 2021 01:33
@dreinon dreinon requested a review from J0 December 1, 2021 23:48
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me. While I have access to the PyPI Repository, it seems like we need to get approval to add secrets to the Github repository. Requesting for that now.

@dreinon
Copy link
Contributor

dreinon commented Dec 2, 2021

tests are failing and I don't really know why, could you please take a look @leynier? Thanks!

@leynier
Copy link
Contributor Author

leynier commented Dec 2, 2021

tests are failing and I don't really know why, could you please take a look @leynier? Thanks!

Yes, I will.

@leynier
Copy link
Contributor Author

leynier commented Dec 2, 2021

@dreinon already tests running fine

@dreinon
Copy link
Contributor

dreinon commented Dec 2, 2021

@leynier codecov/patch is failing, is this meaningful?

@dreinon
Copy link
Contributor

dreinon commented Dec 2, 2021

@leynier tests failing due to connection errors

@leynier
Copy link
Contributor Author

leynier commented Dec 3, 2021

Tests are failing by this supabase/auth-js#188 (comment)

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 3, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.55%.

Quality metrics Before After Change
Complexity 2.49 ⭐ 2.58 ⭐ 0.09 👎
Method Length 46.85 ⭐ 46.99 ⭐ 0.14 👎
Working memory 6.53 🙂 6.38 🙂 -0.15 👍
Quality 79.16% 79.71% 0.55% 👍
Other metrics Before After Change
Lines 2013 2196 183
Changed files Quality Before Quality After Quality Change
gotrue/types.py 80.54% ⭐ 80.44% ⭐ -0.10% 👎
gotrue/_async/client.py 75.48% ⭐ 74.74% 🙂 -0.74% 👎
gotrue/_sync/client.py 75.77% ⭐ 75.03% ⭐ -0.74% 👎
tests/_async/test_client_with_auto_confirm_disabled.py 84.20% ⭐ 84.20% ⭐ 0.00%
tests/_async/test_client_with_auto_confirm_enabled.py 81.61% ⭐ 83.12% ⭐ 1.51% 👍
tests/_sync/test_client_with_auto_confirm_disabled.py 84.34% ⭐ 84.34% ⭐ 0.00%
tests/_sync/test_client_with_auto_confirm_enabled.py 81.80% ⭐ 83.31% ⭐ 1.51% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gotrue/_async/client.py AsyncGoTrueClient.get_session_from_url 14 🙂 215 ⛔ 14 😞 37.49% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.get_session_from_url 14 🙂 213 ⛔ 14 😞 37.63% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.sign_in 11 🙂 115 🙂 10 😞 56.40% 🙂 Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.sign_in 11 🙂 108 🙂 10 😞 57.31% 🙂 Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.__init__ 2 ⭐ 79 🙂 15 😞 62.13% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@dreinon dreinon merged commit 05f493d into supabase:main Dec 3, 2021
@leynier leynier deleted the feat/add-pre-commit-hook-for-conventional-commit branch December 3, 2021 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: add pre-commit hook for force conventional commits style docs: add semantic release github action

4 participants