Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@J0
Copy link
Contributor

@J0 J0 commented Sep 25, 2023

What kind of change does this PR introduce?

To mirror the JS lib. Probably first of a few PRs

cc: @silentworks

joel@joellee.org and others added 2 commits September 25, 2023 23:03
feat: add OAuth PKCE (Sourcery refactored)
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (160b671) 45.68% compared to head (364292c) 45.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   45.68%   45.37%   -0.32%     
==========================================
  Files          23       23              
  Lines        1902     1955      +53     
==========================================
+ Hits          869      887      +18     
- Misses       1033     1068      +35     
Files Coverage Δ
gotrue/types.py 99.05% <100.00%> (+0.02%) ⬆️
gotrue/helpers.py 67.53% <46.15%> (-4.35%) ⬇️
gotrue/_async/gotrue_client.py 29.68% <12.50%> (-0.70%) ⬇️
gotrue/_sync/gotrue_client.py 29.68% <12.50%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 marked this pull request as ready for review November 1, 2023 00:01
Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silentworks silentworks merged commit 8fe633e into main Nov 1, 2023
@silentworks silentworks deleted the j0/pkce branch November 1, 2023 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants