This repository was archived by the owner on Sep 8, 2025. It is now read-only.
feat: exchange code for session now fully async #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 45.40% 45.37% -0.04%
==========================================
Files 23 23
Lines 1958 1955 -3
==========================================
- Hits 889 887 -2
+ Misses 1069 1068 -1 ☔ View full report in Codecov by Sentry. |
silentworks
force-pushed
the
silentworks/async-pkce-flow
branch
from
b5fca51 to
a8afd06
Compare
BREAKING CHANGE: change async method on_auth_state_change to sync only.
silentworks
force-pushed
the
silentworks/async-pkce-flow
branch
from
a8afd06 to
a249ba0
Compare
J0
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: change exchange_code_for_session to async method
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.