Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Add stale bot to mark issues and PRs as Stale after a long period of inactivity.
  • Currently, it does NOT close issues automatically, but it can do so if wanted.
  • Same yaml as Add stale bot supabase-py#774

Additional context

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

- uses: actions/stale@v9
with:
days-before-pr-stale: 365
days-before-pr-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-pr-close' to -1 may prevent PRs from ever being closed.

Consider setting a positive number of days or a clear policy for closing stale PRs to ensure the repository remains clean and manageable.

Suggested change
days-before-pr-close: -1
days-before-pr-close: 30

days-before-pr-stale: 365
days-before-pr-close: -1
days-before-issue-stale: 365
days-before-issue-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-issue-close' to -1 may prevent issues from ever being closed.

It's generally a good practice to have a mechanism to close issues automatically after they become stale to keep the issue tracker clean and focused.

Suggested change
days-before-issue-close: -1
days-before-issue-close: 30

@codecov
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.71%. Comparing base (63e028d) to head (87b27b6).
Report is 67 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   44.71%   44.71%           
=======================================
  Files          23       23           
  Lines        2044     2044           
=======================================
  Hits          914      914           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@J0 J0 merged commit 7059504 into supabase:main May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants